feat: add get_address_utxos method
#134
Conversation
`get_address_utxos` hits the `/address/{address}/utxo` endpoint
and returns a `Vec<Utxo>`
Pull Request Test Coverage Report for Build 16817757977Details
💛 - Coveralls |
There was a problem hiding this comment.
tACK 86d3d44
I've tested it with blocking client, and it worked just fine on both happy path, too many histories error and when it's unconfirmed.
| assert_ne!(address_utxos_blocking.len(), 0); | ||
| assert_ne!(address_utxos_async.len(), 0); | ||
| assert_eq!(address_utxos_blocking, address_utxos_async); |
There was a problem hiding this comment.
You could also add assertions for each field.
There was a problem hiding this comment.
How so? Wouldn't deserialization to the Utxo type fail if the values were incorrect?
| /// Information about an UTXO's status: confirmation status, | ||
| /// confirmation height, confirmation block hash and confirmation block time. | ||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, Deserialize)] | ||
| pub struct UtxoStatus { |
There was a problem hiding this comment.
Thanks for adding docs here. Question: isn't this the same as the TxStatus type?
There was a problem hiding this comment.
Indeed, structurally they are the same. But I preferred to create another struct with a name that matches what it models. We could change the name of TxStatus to something generic, but I don't think that's very elegant, since these types are ad-hoc to what the API returns.
Closes #133.
This PR adds the
get_address_utxosmethod, which hits the/address/{addr}/utxoendpoint, returning aVec<Utxo>.Changelog
UtxoStatus.Utxo.get_address_utxosfor both blocking and async clients.